Test: Secondary bidder #4328

marki1an · 2025-12-24T22:15:11Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

…condary-bidders

osulzhenko

We should make sure the test waits for all primary bidders to respond. We need to ensure the code waits for the last one, not the first. Please add a test case with two primary bidders and one secondary bidder to the spec

osulzhenko · 2026-01-28T12:12:01Z

src/test/groovy/org/prebid/server/functional/model/response/auction/ErrorType.groovy

    OPENX("openx"),
    AMX("amx"),
    AMX_UPPER_CASE("AMX"),
+    OPENX_ALIAS("openxalias"),


why not regular alias?

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

osulzhenko · 2026-01-28T12:13:46Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+    protected static final Bidder openXBidder = new Bidder(networkServiceContainer, "/openx-auction")
+    protected static final Bidder openXAliasBidder = new Bidder(networkServiceContainer, "/openx-alias-auction")


osulzhenko · 2026-01-28T12:13:59Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+    protected static final Bidder openXAliasBidder = new Bidder(networkServiceContainer, "/openx-alias-auction")
+
+    @Shared
+    PrebidServerService pbsServiceWithOpenXAndIXBidder = pbsServiceFactory.getService(OPENX_CONFIG + OPENX_ALIAS_CONFIG)


pbsServiceWithOpenXBidder

osulzhenko · 2026-01-28T12:24:40Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+        assert !bidResponse.ext.seatnonbid
+    }
+
+    def "PBS should emit a warning when null in secondary bidders config"() {


osulzhenko · 2026-01-28T14:47:18Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+        openXAliasBidder.reset()
+    }
+
+    def "PBS shouldn't wait on secondary bidder when alias bidder respond with dilay"() {


Pretty similar to def "PBS shouldn't treated alias bidder as secondary when root bidder code in secondary"

osulzhenko · 2026-01-28T15:01:01Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+        accountDao.save(account)
+
+        and: "Set up openx bidder response with delay"
+        openXBidder.setResponseWithDilay(5)


Delay also should be constant

osulzhenko · 2026-01-28T15:01:17Z

src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/Bidder.groovy

                                : HttpResponse.notFoundResponse()}
    }

+    void setResponseWithDilay(Integer dilayTimeout = 5) {


osulzhenko · 2026-01-28T15:21:28Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+        openXBidder.setResponse()
+        openXAliasBidder.setResponse()


I'm not sure if we need to set response at end of spec

osulzhenko · 2026-01-28T15:44:22Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+            "adapters.openx.enabled" : "true",
+            "adapters.openx.endpoint": "$networkServiceContainer.rootUri/openx-auction".toString()]


replace openx with ${OPENX.value}

osulzhenko · 2026-02-03T11:23:37Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+    private static final Bidder openXBidder = new Bidder(networkServiceContainer, "/openx-auction")
+    private static final Bidder genericAliasBidder = new Bidder(networkServiceContainer, "/generic-alias-auction")


We use openx-auction and generic-alias-auction in several places. Please make them constants

osulzhenko · 2026-02-03T11:26:38Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+
+        cleanup: "Reset mock"
+        openXBidder.reset()
+        genericAliasBidder.reset()


pls make cleanup as separate method

@Override def cleanup() { openXBidder.reset() genericAliasBidder.reset() }

osulzhenko · 2026-02-03T11:37:13Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+    def "PBS shouldn't emit a warning when empty secondary bidders config"() {
+        given: "Default basic BidRequest with generic bidder"
+        def bidRequest = BidRequest.defaultBidRequest.tap {
+            enabledReturnAllBidStatus()
+        }
+
+        and: "Account in the DB"
+        def accountConfig = AccountConfig.defaultAccountConfig.tap {
+            it.auction = new AccountAuctionConfig(secondaryBidders: [null])
+        }
+        def account = new Account(uuid: bidRequest.accountId, config: accountConfig)
+        accountDao.save(account)
+
+        when: "PBS processes auction request"
+        def bidResponse = pbsServiceWithOpenXBidder.sendAuctionRequest(bidRequest)
+
+        then: "PBs should processed bidder request"
+        assert bidder.getBidderRequest(bidRequest.id)
+
+        and: "PBS shouldn't contain errors, warnings and seat non bid"
+        assert !bidResponse.ext?.warnings
+        assert !bidResponse.ext?.errors
+        assert !bidResponse.ext?.seatnonbid
+    }
+
+    def "PBS shouldn't emit a warning when invalid bidder in secondary bidders config"() {
+        given: "Default basic BidRequest with generic bidder"
+        def bidRequest = BidRequest.defaultBidRequest.tap {
+            enabledReturnAllBidStatus()
+        }
+
+        and: "Account in the DB"
+        def accountConfig = AccountConfig.defaultAccountConfig.tap {
+            it.auction = new AccountAuctionConfig(secondaryBidders: [UNKNOWN])
+        }
+        def account = new Account(uuid: bidRequest.accountId, config: accountConfig)
+        accountDao.save(account)
+
+        when: "PBS processes auction request"
+        def bidResponse = pbsServiceWithOpenXBidder.sendAuctionRequest(bidRequest)
+
+        then: "PBs should processed bidder request"
+        def bidderRequests = bidder.getBidderRequests(bidRequest.id)
+        assert bidderRequests.size() == 1
+
+        and: "PBS shouldn't contain errors, warnings and seat non bid"
+        assert !bidResponse.ext?.warnings
+        assert !bidResponse.ext?.errors
+        assert !bidResponse.ext?.seatnonbid
+    }


Can be combined with a where block to handle invalid secondary bidders

osulzhenko · 2026-02-03T11:45:52Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+        def bidRequest = BidRequest.defaultBidRequest.tap {
+            it.imp[0].ext.prebid.bidder.openx = Openx.defaultOpenx
+            enabledReturnAllBidStatus()
+        }


we can add private method:

private void getEnrichedBidRequest(List<BidderName> bidderNames) { BidRequest.defaultBidRequest.tap { if (bidderNames.contains(OPENX)) { it.imp[0]?.ext?.prebid?.bidder?.openx = Openx.defaultOpenx } if (bidderNames.contains(ALIAS)) { it.imp[0]?.ext?.prebid?.bidder?.alias = new Generic() } enabledReturnAllBidStatus() } }

osulzhenko · 2026-02-03T11:46:24Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+
+        and: "Set up openx bidder response with delay"
+        openXBidder.reset()
+        openXBidder.setResponseWithDelay(2)


magic number

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

osulzhenko · 2026-02-03T11:48:07Z

src/test/groovy/org/prebid/server/functional/tests/SecondaryBidderSpec.groovy

+        assert openXAliasBidderRequests.size() == 1
+
+        and: "PBs repose shouldn't contain response body from openX bidder"
+        assert !bidResponse?.ext?.debug?.httpcalls[OPENX]?.responseBody


marki1an and others added 6 commits December 9, 2025 12:56

Test: Remove post in pr-java-ci.yml (#4307)

1ad9288

Decrease the version of the InfluxDB metrics (#4292)

17d7aed

Prebid Server prepare release 3.37.0

3dc5e77

Prebid Server prepare for next development iteration

01acd95

Fix vulnerability in cross-repo-issue GitHub action (#4324)

033af31

Add functional tests for Secondary Bidder faute

932446c

marki1an self-assigned this Dec 24, 2025

marki1an added the tests Functional or other tests label Dec 24, 2025

Fix NPE when removing invalid config.

09a3cc0

osulzhenko self-requested a review January 2, 2026 09:18

osulzhenko added the work in progress Signals not finished work label Jan 2, 2026

marki1an added 2 commits January 7, 2026 11:23

Merge remote-tracking branch 'origin/secondary-bidders' into tests/se…

8592109

…condary-bidders

Minor update

311d45d

marki1an changed the base branch from master to secondary-bidders January 7, 2026 14:03

marki1an removed the work in progress Signals not finished work label Jan 7, 2026

marki1an added 2 commits January 7, 2026 16:24

Merge branch 'master' into tests/secondary-bidders

78eb6de

Minor updates

65678b4

osulzhenko added blocked and removed blocked labels Jan 16, 2026

osulzhenko requested changes Jan 28, 2026

View reviewed changes

marki1an added 2 commits January 29, 2026 16:53

Update after review

6f17876

Last updated

b74ed13

osulzhenko requested changes Feb 3, 2026

View reviewed changes

		protected static final Bidder openXBidder = new Bidder(networkServiceContainer, "/openx-auction")
		protected static final Bidder openXAliasBidder = new Bidder(networkServiceContainer, "/openx-alias-auction")

		"adapters.openx.enabled" : "true",
		"adapters.openx.endpoint": "$networkServiceContainer.rootUri/openx-auction".toString()]

		private static final Bidder openXBidder = new Bidder(networkServiceContainer, "/openx-auction")
		private static final Bidder genericAliasBidder = new Bidder(networkServiceContainer, "/generic-alias-auction")

Test: Secondary bidder #4328

Are you sure you want to change the base?

Test: Secondary bidder #4328

Conversation

marki1an commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

osulzhenko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marki1an commented Dec 24, 2025 •

edited

Loading